Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PLT-820: Increase BCDA rate limit to 3000 #155

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

PLT-820: Increase BCDA rate limit to 3000 #155

wants to merge 1 commit into from

Conversation

gfreeman-navapbc
Copy link
Contributor

🎫 Ticket

https://jira.cms.gov/browse/PLT-820

🛠 Changes

Removed the line making BCDA's limit 300/5min

ℹ️ Context

https://cmsgov.slack.com/archives/CHG7Q7XNH/p1734444527725299?thread_ts=1734019554.318099&cid=CHG7Q7XNH

@ Grant Freeman let's 10x BCDA's rate limit from 300 requests / 5 minutes to 3000 requests / 5 minutes to match DPC. This will help us:

  1. meet the needs for Maryland TCoC above (many file downloads for 1 entity)
  2. address a previous request from Aledade (many entities for 1 IP address)

🧪 Validation

This should be verifiable by checking the rate limit rule no the BCDA WAFs

@gfreeman-navapbc gfreeman-navapbc self-assigned this Dec 17, 2024
@gfreeman-navapbc gfreeman-navapbc requested a review from a team as a code owner December 17, 2024 15:51
@laurenkrugen-navapbc
Copy link
Contributor

is there a default value for waf of 3000 / 5 mins? I see the line removed, but I don't see that 3k set elsewhere in the file.

carlpartridge
carlpartridge reviewed Dec 17, 2024
View reviewed changes
Copy link

@carlpartridge carlpartridge left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3000 is set somewhere else or is that the default?

I found:

variable "rate_limit" {
  description = "IP rate limit for every 5 minutes"
  type        = number
  default     = 3000
}

But that would be roughly 600/min. I believe ours is currently at 300/min, and if so, then this doesnt increase it very much.

@bhagatparwinder
Copy link

3000 is set somewhere else or is that the default?

I found:

variable "rate_limit" {
  description = "IP rate limit for every 5 minutes"
  type        = number
  default     = 3000
}

But that would be roughly 600/min. I believe ours is currently at 300/min, and if so, then this doesnt increase it very much.

Did it go from 300/5 minutes to 3000/5 minutes OR did it go from 300/minute to 3000/5 minutes?

If it is the latter, then I agree we are only doubling and not 10x-ing it.

@gsf
Copy link
Member

gsf commented Dec 18, 2024

It went from 300 per 5 minutes to 3000 per 5 minutes: https://github.com/CMSgov/ab2d-bcda-dpc-platform/pull/154/files#diff-a3da7ef40aca878a80acb7a6f49fe9b01e38b6aee1193c7f88ca6a6d20529006R51

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlpartridge carlpartridge carlpartridge left review comments

@bhagatparwinder bhagatparwinder bhagatparwinder approved these changes

At least 1 approving review is required to merge this pull request.

Assignees

@gfreeman-navapbc gfreeman-navapbc

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gfreeman-navapbc @laurenkrugen-navapbc @bhagatparwinder @gsf @carlpartridge